On Wed, Apr 20, 2016 at 6:42 PM, Chris Johns <chr...@rtems.org> wrote:
> On 21/04/2016 9:01 AM, Joel Sherrill wrote:
> > Console/Printk Device Selection
> > ===============================
> > @@ -19,9 +19,9 @@ in the following order of priority:
> > + VGA and keyboard
> > + COM1 through COM4aaa
> >
> > What is the aaa?
> >
>
> No idea, must have been cat on the keyboard.
>
> > +
> > + if (comma) {
> > + option = comma + 1;
> > + baudrate = strtoul(option, 0, 10);
> > + switch (baudrate) {
> > + case 115200:
> > + case 57600:
> > + case 38400:
> > + case 19200:
> > + case 9600:
> > + case 4800:
> > + port->pDeviceParams = (void*) baudrate;
> > + BSPBaseBaud = baudrate; /* REMOVE ME */
> > + break;
> > + default:
> > + printk("invalid option (--gdb): bad baudrate\n");
> > + return;
> > + }
> > + }
> >
> >
> > Is there anyway the code parsing this option can be shared with that
> > for the com ports?
>
> Yes that could be done but I do not think so for this patch set. This is
> in code in shared/comm and the BSP code needs to be reorganised.
>
> Given the conversation with Sebastian about consoles this BSP needs some
> rework. Maybe this can happen then.
>
> I am ok with letting it go. Opportunities for shared code have to be noted
or
they never happen.
Fix the cat scratches and commit. :)
> Chris
>
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
