On Tue, Apr 19, 2016 at 10:41 AM, Gedare Bloom <ged...@rtems.org> wrote:
> On Tue, Apr 19, 2016 at 9:59 AM, Joel Sherrill <j...@rtems.org> wrote: > > A few quick things. > > > > Add a bspimpl.h which is private to the bsp. Do not put anything in bsp.h > > which > > does not need to be public to the application. We have been exceedingly > > uncaring about this in the past and the software tax to correct it is > going > > to > > be painful. In general, the bsp.h probably doesn't need much except to > > provide the BSP defaults for confdefs.h if it needs to change them. > > And no.. there aren't any great examples yet. > > > > Another point is to check the current .cfg files for examples of how > to add the per-function and per-sections LTO > +1 that would be a good think for the script to check. As well as for the console table structure Sebastian recommended not using. Also the new code should be warning free. It should also not result in warnings in formerly warning free shared code. The script isn't great but if we can use grep to help us review for repeat offenders, then we can focus on harder issues. --joel
_______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
