[ Sorry, laptop slipped and it sent the email ... ] On 2/02/2016 9:49 PM, Chris Johns wrote: > On 2/02/2016 7:25 PM, Sebastian Huber wrote: >> >>> >>> How do we want to proceed? Chris, what is your opinion with respect to >>> this EXTERN magic? >>> >>> some.h >>> >>> #ifndef SOME_XYZ_EXTERN >>> #define SOME_XYZ_EXTERN extern >>> #endif >>> >>> SOME_XYZ_EXTERN type xyz; >>> >>> some_xyz.c >>> >>> #define SOME_XYZ_EXTERN >>> #include <some.h> >>> >>> vs. >>> >>> some.h >>> >>> extern type xyz; >>> >>> some_xyz.c >>> >>> #include <some.h> >>> type xyz; >>> >> >> We have 2:1 against the EXTERN pattern, so I will commit the patches >> tomorrow if nobody objects in the meantime. >> > > I do not object to the patch or the change. The need to discuss the
.. change is important because the current pattern has been present for a long time. We need to be mindful and to show respect when making these changes. I think it is important the global or extern data is declared in a uniform manner. Chris _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
