I just had one comment from reading the code, it lacks any code-level documentation. Granted it is simple now, but as it grows so should the doc.
Also, make sure to watch out for when to break out into more functions/modules. Avoid the pitfall of "one block of code to rule them all" -Gedare On Mon, Jun 15, 2015 at 6:49 PM, Amar Takhar <a...@rtems.org> wrote: > On 2015-06-15 23:52 +0530, Anand Krishnan wrote: >> Hi all, >> >> Currently I have uploaded the first part of the gui - just plain menus (with >> no >> event handlers yet) to my github: github.com/anandkp92/waf/gui/menu.py . The >> purpose of the GUI is for creating the config.cfg file for "waf config" of >> the >> waf version of RTEMS. > > Looks good so far. > > >> I think you might need wxpython also to view it right now: http:// >> www.pygopar.com/installing-wxpython-3-on-ubuntu14-04/ > > Everyone here will be able to sort that out, thanks for the help. :) > > >> The main thing I want to get reviewed on is the code. I am planning to have >> different classes for menus, tabs, groups etc and a main class that creates >> multiple instances of each and puts it all together. > > It seems like a good start. > > >> Correct me if I am wrong: >> For the File options-> >> 1) New -> Opens a new instance with all the configuration options set to >> default again. > > Yes. > > >> 2) Save -> Save the configuration options chosen so far. > > Yes. > > >> 3) Open -> Open a previously saved set of configuration options. > > Yep. > > >> Once this is cleared, I shall move on to implementing these. > > OK. > > >> Please keep in mind this is a very crude version and the first part of many >> parts. > > Right. Lay out the panes and other UI Details before getting on to actual > options. I will help you with that. > > You will also need to decide how each option should be displayed. > > > Amar. > > _______________________________________________ > devel mailing list > devel@rtems.org > http://lists.rtems.org/mailman/listinfo/devel _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
