On May 29, 2015 10:45:27 AM CDT, Sebastian Huber <sebastian.hu...@embedded-brains.de> wrote: > >----- Joel Sherrill <joel.sherr...@oarcorp.com> schrieb: >> >> >> On 5/29/2015 8:37 AM, Sebastian Huber wrote: >> > Module: rtems >> > Branch: master >> > Commit: 5611839a7e2e371dd1f327c336c785095f634e55 >> > Changeset: >http://git.rtems.org/rtems/commit/?id=5611839a7e2e371dd1f327c336c785095f634e55 >> > >> > Author: Sebastian Huber <sebastian.hu...@embedded-brains.de> >> > Date: Fri May 29 14:18:32 2015 +0200 >> > >> > tmtests/tm26: Avoid NULL pointer access >> > >> > --- >> > >> > testsuites/tmtests/tm26/task1.c | 3 --- >> > 1 file changed, 3 deletions(-) >> > >> > diff --git a/testsuites/tmtests/tm26/task1.c >b/testsuites/tmtests/tm26/task1.c >> > index 6cec7da..ee66218 100644 >> > --- a/testsuites/tmtests/tm26/task1.c >> > +++ b/testsuites/tmtests/tm26/task1.c >> > @@ -439,9 +439,6 @@ rtems_task Low_task( >> > thread_disable_dispatch(); >> > >> > benchmark_timer_initialize(); >> > -#if (CPU_HARDWARE_FP == 1) || (CPU_SOFTWARE_FP == 1) >> > - _Context_Restore_fp( &_Thread_Get_executing()->fp_context ); >> > -#endif >> >> What impact does this have on the case being timed? >> >> How did this fault? What configuration? > >Sorry, I didn't fault. I was stupid enough to look at >"executing->fp_context" in the GDB. I will revert this patch. > >The main problem is that this test restores an FP context without the >FPU enabled. I have to figure out how we can avoid this.
Perhaps test routines that wrap all these calls in the score? That would eliminate the api violation as well. >> >> > _Context_Switch( >> > &executing->Registers, >> > &_Thread_Get_executing()->Registers >> > >> > _______________________________________________ >> > vc mailing list >> > v...@rtems.org >> > http://lists.rtems.org/mailman/listinfo/vc >> > >> >> -- >> Joel Sherrill, Ph.D. Director of Research & Development >> joel.sherr...@oarcorp.com On-Line Applications Research >> Ask me about RTEMS: a free RTOS Huntsville AL 35805 >> Support Available (256) 722-9985 >> _______________________________________________ >> devel mailing list >> devel@rtems.org >> http://lists.rtems.org/mailman/listinfo/devel --joel _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
