On 15/12/14 03:32, Nick Withers wrote:
On Thu, 2014-12-11 at 08:25 +0100, Sebastian Huber wrote:
>Hello Nick,
>
>this looks good, except that
>
>On 10/12/14 06:05, Nick Withers wrote:
> >+ for (pos = response; response + sizeof (response) - pos && (size =
read(ctx->socket, pos, response + sizeof (response) - pos)) > 0; pos += size)
> >+ ;
>
>this line is too long and complex. It appears also multiple times.
>Maybe use a function for this. It would be nice if you can use a line
>limit of 79 chars.
Sorry - I should know better.
How's the attached?
P.S.: I also sprayed come consts around
Thanks, I checked it in:
http://git.rtems.org/rtems/commit/?id=f42d4292cbbfa445ab8b89545832960da325fb2f
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.hu...@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
