On 11/1/2014 1:38 PM, Gedare Bloom wrote:
On Sat, Nov 1, 2014 at 1:12 PM, Alan Cudmore <alan.cudm...@gmail.com> wrote:
There are two warnings in the raspberry pi BSP due to the lack of prototypes
in simple_abort.c
the rtl22xx BSP has the same warnings because it also uses simple_abort.c.
Many of the other ARM BSPs use abort.c, which has prototypes for the two
functions.
The two functions in simple_abort.c and abort.c are nearly the same.
Does anyone know why there is a simple_abort.c ?
The potential fixes include:
1. removing simple_abort.c and have the Raspberry Pi and rtl22xx BSPs use
abort.c or
2. simply putting the prototypes in simple_abort.c to take care of the
warnings.
I prefer #1. I also would like to see the prototypes in abort.c go away.
OK.
It looks like the difference is that simple_abort.c uses less memory for
the ARM CPUs that are very limited. I must have based the original Pi
BSP on a BSP that used simple_abort.c instead of abort.c
I can keep simple_abort.c if we feel that the savings are still needed.
At this point only the rtl22xx BSP would use it.
As for the prototypes, I can create a header. Should it go in
libbsp/arm/shared/include or just in libbsp/arm/shared/abort?
For example, I see that libbsp/arm/shared/uart has a uart.h.
Also, if we keep simple_abort.c, it looks like both files could use the
same header, since the defines and prototypes are the same.
Alan
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
