On Tue, Aug 12, 2014 at 7:32 AM, Peter Dufault <dufa...@hda.com> wrote: > > On Aug 11, 2014, at 17:02 , Gedare Bloom <ged...@rtems.org> wrote: > >>> +#ifdef ARM_MULTILIB_VFP >>> + /* CPACR is located at address 0xe000ed88 */ >>> + ldr.w r0, =0xe000ed88 >> Maybe the constant should be provided by a header file? The comments >> are nice though. And I didn't see anything else in the rest, although >> my arm asm is rusty. >> >> > > When used in a single place in a hardware specific C file I prefer a > constant. When I'm suspicious I'm comparing definitions against the > reference manuals looking for transcription errors and I'd rather avoid the > indirection. Obviously it needs an appropriate constant (which Sebastian > provides). > True, and the comment is pretty clear. So, either way. I guess I am surprised the constant is only used in this one place. -Gedare
> Peter > ----------------- > Peter Dufault > HD Associates, Inc. Software and System Engineering > _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
