On 2014-06-30 13:23, Daniel Hellstrom wrote:
hardware. The GRLIB APBUART is compatible on most or if not all aspects with the LEON2 AT697 UART, however the APBUART have more features that are currently not in use. I think it would be better to call the LEON3 BSP UART "APBUART" and the LEON2 UART simply "LEON2 UART" and the common bit definitions could perhaps have a common name but not APBUART_*? It might be misleading to use APBUART_ definitions in the LEON2 code? For example LEON2 UART.STATUS.TH bit is named TE in in APBUART since they signal different things, I can see you are renaming from _THE into _TE in the LEON2 driver. I think I would prefer to just change the LEON3 console driver into APBUART_ something.
Ok, I removed the LEON2 changes from the patch. For me this stuff looked similar enough. The APBUART seems to be backward compatible since the new features use new bits and all old bits are still present and have the same function?
I think there is a considerable amount of copy and paste in the LEON BSPs. -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.hu...@embedded-brains.de PGP : Public key available on request. Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG. _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
