On Thu, Dec 2, 2021 at 8:02 AM Ales Musil <[email protected]> wrote:

>
>
> On Wed, Dec 1, 2021 at 11:28 PM Nir Soffer <[email protected]> wrote:
>
>> On Wed, Dec 1, 2021 at 11:11 PM Nir Soffer <[email protected]> wrote:
>> >
>> > I'm trying to add a github action workflow for ovirt-imageio.
>> >
>> > The yml file is simple:
>> >
>> https://github.com/nirs/ovirt-imageio/commit/21da91274b7b4722167c2415d1c1b5db08c5e88b
>> >
>> > And all the jobs run, but tons of tests are failing:
>> > https://github.com/nirs/ovirt-imageio/actions/runs/1527728851
>>
>> Solved by not using github "container" option. Instead, just run
>> docker manually like we did in travis.
>>
>>
>> https://github.com/nirs/ovirt-imageio/commit/6fb94e9423c1642af716e3327038835fc09d225c
>>
>> Notes for others that my have the same issue:
>>
>>     docker run -it ...
>>
>> fails in github action with:
>>
>>     "the input device is not a TTY"
>>
>> Removing the "-it" options solves this problem. The output of the command
>> running in the container logged to stdout. I don't know why we always run
>> the container with -it.
>>
>> So we have working github CI for ovirt-imageio:
>> https://github.com/nirs/ovirt-imageio/actions/runs/1528026365
>>
>> Running tests on centos stream 8, centos stream 9, and fedora 34 in 4
>> minutes.
>>
>> I think the only thing missing to move to github, is to build the rpms in
>> a way
>> that can be used by OST.
>>
>> Nir
>>
>>
> AFAIK enabling ipv6 can be done inside the container by running:
> sysctl -w net.ipv6.conf.all.disable_ipv6=0
>

Looks simpler, I will try it once github CI is merged.


>
> Might be worth doing this instead of the additional docker configuration
> and restarting the whole service.
>
> Regards,
> Ales
>
>
> --
>
> Ales Musil
>
> Software Engineer - RHV Network
>
> Red Hat EMEA <https://www.redhat.com>
>
> [email protected]    IM: amusil
> <https://red.ht/sig>
>
_______________________________________________
Devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/[email protected]/message/JQSLUKYEI6JX3F7RDTE2UE4TJ6TONWCV/

Reply via email to