Henning Westerholt wrote:
On Thursday 19 July 2007, Anca Vamanu wrote:
Revision: 2485
          http://openser.svn.sourceforge.net/openser/?rev=2485&view=rev
Author:   anca_vamanu
Date:     2007-07-19 07:34:45 -0700 (Thu, 19 Jul 2007)

Log Message:
-----------
- added some KEYs to presence tables to improve db query performance (table
version increased) - did some cleanup (corrected some log messages, a bit
of restructuring )

Modified Paths:
--------------
    trunk/db/schema/pr_active_watchers.xml
    trunk/db/schema/pr_presentity.xml
    trunk/modules/presence/README

Hello Anca,

just a short note..

You've included the generated SQL code in the README file as well. This is of course good, but i have a question/ suggestion:

I've noticed that quite a few modules includes some SQL code in their documentation, mostly of this is outdated. Perhaps we can remove this SQL, and simply add a note that this code is located in the scripts/mysql dir (for mysql) and perhaps also add a link to the database documentation on the web site? This way its easy to update this db stuff, and no documentation update will be forgotten.

I prefer this too. There should not be DB definitions in README files or on the wiki.

regards
klaus

What do you think?

Henning

_______________________________________________
Devel mailing list
[email protected]
http://openser.org/cgi-bin/mailman/listinfo/devel

_______________________________________________
Devel mailing list
[email protected]
http://openser.org/cgi-bin/mailman/listinfo/devel

Reply via email to