Are you sure this is a good idea? Releasing with -Werror means that when minor warnings pop up with different/newer toolchains (like the ones you are addressing in the rest of this patch set), distros and self-compiling users get screwed. It's a good idea to fix warnings as they pop up, but -Werror by default is asking for trouble as you're not testing all the toolchains that will be used to compile this source.
- Chris On Wed, Oct 24, 2012 at 1:49 PM, Mark Rustad <[email protected]> wrote: > Signed-off-by: Mark Rustad <[email protected]> > Tested-by: Ross Brattain <[email protected]> > --- > > Makefile.am | 2 +- > configure.ac | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile.am b/Makefile.am > index 1fcd8b7..15d2182 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -5,7 +5,7 @@ sbin_PROGRAMS = fcoeadm fcoemon fcping fipvlan fcnsq fcrls > AM_CPPFLAGS = -I${srcdir}/include -I${builddir}/include > ## pass the sysconfdir into the C proprocessor > AM_CPPFLAGS += -DSYSCONFDIR="\"${sysconfdir}\"" > -AM_CFLAGS = -Wall > +AM_CFLAGS = -Wall -Werror > > ## rules for building fcoeadm > fcoeadm_SOURCES = fcoeadm.c fcoeadm_display.c > diff --git a/configure.ac b/configure.ac > index 3e82ab2..b3cc5b0 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1,5 +1,5 @@ > AC_INIT([fcoe-utils], [1.0.25], [[email protected]]) > -AM_INIT_AUTOMAKE([-Wall -Werror foreign]) > +AM_INIT_AUTOMAKE([foreign]) > > AC_PROG_CC > AM_PROG_CC_C_O > > _______________________________________________ > devel mailing list > [email protected] > https://lists.open-fcoe.org/mailman/listinfo/devel _______________________________________________ devel mailing list [email protected] https://lists.open-fcoe.org/mailman/listinfo/devel
