Hi Chris,

We are going to resubmit VLAN discovery patch according to Rob's
suggestion and at that time we will make sure your pointers also get
corrected in new patch.

Thanks,
Hiral

On 8/20/12 4:21 PM, "Chris Leech" <[email protected]> wrote:

>On Mon, Aug 20, 2012 at 11:42:36AM -0700, Hiral Patel wrote:
>> From: Anantha Prakash T <[email protected]>
>> 
>> Signed-off-by: Anantha Prakash T <[email protected]>
>> Signed-off-by: Hiral Patel <[email protected]>
>> ---
>>  drivers/scsi/fnic/fnic.h        |   35 +++-
>>  drivers/scsi/fnic/fnic_fcs.c    |  560
>>++++++++++++++++++++++++++++++++++++++-
>>  drivers/scsi/fnic/fnic_fip.h    |   69 +++++
>>  drivers/scsi/fnic/fnic_main.c   |   50 ++++-
>>  drivers/scsi/fnic/vnic_dev.c    |   10 +
>>  drivers/scsi/fnic/vnic_dev.h    |    2 +
>>  drivers/scsi/fnic/vnic_devcmd.h |   67 +++++
>>  7 files changed, 789 insertions(+), 4 deletions(-)
>>  create mode 100644 drivers/scsi/fnic/fnic_fip.h
>
>An almost 800 line in-kernel FIP VLAN discovery implementation, and it
>doesn't deserve any description beyond the one-line mail subject?
>
>> diff --git a/drivers/scsi/fnic/fnic_fip.h b/drivers/scsi/fnic/fnic_fip.h
>> new file mode 100644
>> index 0000000..d958bec
>> --- /dev/null
>> +++ b/drivers/scsi/fnic/fnic_fip.h
>> @@ -0,0 +1,69 @@
>> +/*
>> + * Copyright 2008 Cisco Systems, Inc.  All rights reserved.
>> + * Copyright 2007 Nuova Systems, Inc.  All rights reserved.
>
>Are we to believe that this new file was actually created 5-years ago?
>
>- Chris
>_______________________________________________
>devel mailing list
>[email protected]
>https://lists.open-fcoe.org/mailman/listinfo/devel

_______________________________________________
devel mailing list
[email protected]
https://lists.open-fcoe.org/mailman/listinfo/devel

Reply via email to