On Thu, Jan 12, 2023 at 06:29:10PM -0500, Siddhesh Poyarekar wrote:
> On Thu, Jan 12, 2023 at 12:41 PM Jakub Jelinek <[email protected]> wrote:
> > > I've filed a ccache bug. It looks like ccache is moving the compiler
> > > arguments around, causing one of the -U_FORTIFY_SOURCE to the end.
> > >
> > > https://bugzilla.redhat.com/show_bug.cgi?id=2160275
> >
> > Why we do have those -U_FORTIFY_SOURCE and -Wp,-U_FORTIFY_SOURCE options
> > in there at all? Previously we just had -Wp,-D_FORTIFY_SOURCE=2
> > and I think just changing it to -Wp,-D_FORTIFY_SOURCE=3 is more than enough.
> > If you think some programs are adding -D_FORTIFY_SOURCE=2 to their *FLAGS
> > make vars etc., then perhaps -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3
> > But having both -U_FORTIFY_SOURCE and -Wp,-U_FORTIFY_SOURCE seems completely
> > pointless to me.
>
> A number of packages have -D_FORTIFY_SOURCE=2 in their default build
> flags, which was fine before because the redefinition didn't actually
> change the value of the macro. That unfortunately fails with
> -D_FORTIFY_SOURCE=3 since the macro now gets redefined to a different
> value, resulting in a compile time warning.
>
> As a result we need to undefine any previous macro definition and
> define it to 3. There were more than 20 packages IIRC and asking the
> upstreams to change for this didn't make sense, but I'm happy to
> explore other ideas, if any.
But at least you don't need both -U_FORTIFY_SOURCE and
-Wp,-U_FORTIFY_SOURCE, one of them is enough. And the latter I think
better gets through libtool and other tools; especially if you put it
into a single -Wp, option together with the redefinition...
Jakub
_______________________________________________
devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
