On Tue, Aug 3, 2021 at 1:54 PM Florian Weimer <[email protected]> wrote:
> * Kaleb Keithley: > > > ah, I missed that. I looked, but not hard enough apparently, and I > presumed it was related > > to changes in the code. > > > > <https://github.com/google/leveldb/issues/927> > > > > but I expect upstream does not care about ABI. > > > > Maybe the other way would be to patch that change back out in Fedora. > > Since f34 has been updated to leveldb-1.23 too (in testing) maybe > > that's a better solution to preserve the ABI and also not bump the > > soname? > > Yeah, reverting -fno-rtti downstream probably is the right approach, at > least in the short term. Maybe in the long term as well: it's not > reasonable to expect everyone that uses leveldb to build with -fno-rtti. > hmm. It looks to me like I have sufficient privs to merge this PR https://src.fedoraproject.org/rpms/leveldb/pull-request/1# And probably to fire off a build too. I didn't expect I could do that to someone else's package. Any reason not to? -- Kaleb
_______________________________________________ devel mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
