On Tue, Dec 31, 2019 at 11:06:11AM +0100, Jacek Danecki wrote:
> Hi,
> 
> I've been using Linux for above 20 years. I've been involved in many Linux 
> projects
> mainly closed sourced, but also open sourced:
> [1] isci kernel driver
> [2] dmraid
> [3] mdadm
> [4] KaNaPi
> [5] Neo
> 
> I was working with some of you on adding mdadm support in Anaconda for Fedora 
> 11.
> I'm preparing weekly releases for Neo on github [6].
> Since last year I've been preparing deb packages for Neo on launchpad [7], 
> [8], [9].
> For about 5 months I've been maintaining rpm packages for Neo on copr [10].
> Few weeks ago I've started with OBS [11].
> I'm maintaining CI systems for Neo [12], [13], [14] and docker images with 
> Neo on docker hub [15].
> 
> As Benson mentioned [16] few months ago on this mailing list, I'd plan to add 
> Neo packages to Fedora.
> Before I send review request I need to split opencl-clang spec [17], switch 
> to use gmmlib from Fedora,
> and clean specs for IGC [18] and Neo [19].

Hi Jacek,

welcome to Fedora. Sounds like you have quite a TODO list already,
good luck!

> [18] 
> https://github.com/JacekDanecki/neo-specs/blob/master/specs/fedora/31/igc.spec
Some random notes to get you started ;)

cd build
%make_install
→ %make_install -C build

$RPM_BUILD_ROOT → %buildroot
(not mandatory, but it makes the package seem more modern ;). Mageia
outright disallows $RPM_BUILD_ROOT...)

%defattr(-,root,root)
Group: System Environment/Libraries
→ not needed, should be removed.

/usr/lib64/libigdfcl.so.*
→ please use something like
%{_libdir}/libigdfcl.so.NN
%{_libdir}/libigdfcl.so.NN.*
(macro not dir, and the so-version cannot change without you noticing.)

Looks quite OK otherwise.

Zbyszek
_______________________________________________
devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to