On Fri, Mar 23, 2018 at 11:53 PM, Adam Williamson
<[email protected]> wrote:
> It's due to this change in upstream poppler:
>
> https://cgit.freedesktop.org/poppler/poppler/commit/poppler/Dict.h?id=8794789a72f845b009656e6d7ae6a00b709e09bc
>
> I think it suggests texlive is actually doing something wrong in how it
> uses that Dict class provided by poppler, but I am not an expert on C++
> classes and not super enthusiastic about trying to become one at 11pm
> on a Friday. If no-one else gets to this by tomorrow afternoon I may
> take the University of Stack Overflow C++ 201 class and have a go at
> it. :P
The bug is in texlive-20170520-new-poppler.patch, so we did this to
ourselves. These two lines:
Dict dic1 = page->getGroup();
Dict dic2 = groupDict.getDict();
demand that copies be made. There is no need for copies there. Those
should be constant references instead. I've made that change to the
patch, pushed it, and started a build. A mock build completed
successfully, so I have reason to be optimistic. :-)
Regards,
--
Jerry James
http://www.jamezone.org/
_______________________________________________
devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
