Hi, It seems that this patch has been left unattended.
The empty string "" may be ambiguous, as it could imply that the string is valid but contains no characters, or it has not been filled. On Ampere platforms, I utilize "Not Set" to avoid this confusion, which is effective for FWTS. Regards, Nhi ________________________________ From: [email protected] <[email protected]> on behalf of Sam Kaynor via groups.io <[email protected]> Sent: Wednesday, November 9, 2022 10:10 PM To: [email protected] <[email protected]> Cc: Sam Kaynor <[email protected]>; Leif Lindholm <[email protected]>; Ard Biesheuvel <[email protected]>; Sami Mujawar <[email protected]> Subject: [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to "" Current default values in uni files are set to "Not Specified". This value causes errors in DMI tables when running FWTS tests. To avoid these errors and align more closely with the SMBIOS spec, the default value is changed from "Not Specified" to empty string "". REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4066 Cc: Leif Lindholm <[email protected]> Cc: Ard Biesheuvel <[email protected]> Cc: Sami Mujawar <[email protected]> Signed-off-by: Sam Kaynor <[email protected]> Sam Kaynor (1): ArmPkg: Smbios: UNI file default values ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni | 12 ++++++------ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni | 8 ++++---- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni | 12 ++++++------ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni | 14 +++++++------- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni | 10 +++++----- 5 files changed, 28 insertions(+), 28 deletions(-) -- 2.34.1 -=-=-=-=-=-= Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96133): https://edk2.groups.io/g/devel/message/96133 Mute This Topic: https://groups.io/mt/94914657/5228573 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-= -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120525): https://edk2.groups.io/g/devel/message/120525 Mute This Topic: https://groups.io/mt/94914657/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
