> -----Original Message----- > From: Laszlo Ersek <[email protected]> > Sent: Thursday, July 16, 2020 5:20 AM > To: Vladimir Olovyannikov <[email protected]>; > [email protected] > Cc: Samer El-Haj-Mahmoud <[email protected]>; Zhichao > Gao <[email protected]>; Maciej Rabeda > <[email protected]>; Jiaxin Wu <[email protected]>; Siyuan > Fu <[email protected]>; Ray Ni <[email protected]>; Liming Gao > <[email protected]>; Nd <[email protected]> > Subject: Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add > HttpDynamicCommand > > On 07/15/20 19:09, Vladimir Olovyannikov wrote: > > Hi Laszlo, > > > > Thank you for supporting this. > > I can add required support. > > Thanks! > > > But shouldn't we wait until the patch is reviewed and approved first? > > I don't know the proper procedure. Please advise. > > If a v4 of your patch becomes necessary, based on the ShellPkg > maintainers' > review, then my suggestion would be to send v4 as a patch series, not as a > single patch. The v4 1/3 patch would be the current patch (with updates as > requested by the ShellPkg reviewers). The v4 2/3 patch would extend > ArmVirtPkg to include the new dynamic command. The v4 > 3/3 patch would do the same for OvmfPkg. > > If a v4 of your patch turns out to be unnecessary (i.e., in case the > ShellPkg > maintainers merge your v3 patch as-is), then sending a separate 2-part > series > (1/2: ArmVirtPkg, 2/2: OvmfPkg) would be straightforward, in my opinion. > > Thank you for considering my request (and for implementing the feature in > the first place, of course)! > > Laszlo Thank you Laszlo, Sure, this makes sense. I will send a patchset for ArmVirtPkg and OvmfPkg as you suggested.
Vladimir -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62708): https://edk2.groups.io/g/devel/message/62708 Mute This Topic: https://groups.io/mt/75483573/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
