Hello,

To your attention: at https://github.com/cyrusimap/cyrus-imapd/pull/3506/commits/35b224938601f477f0ddc5173875933fd8f87fa6 I made the commit below, which got this comment:

Thanks for fixing these typos, @dilyanpalauzov

However, I do request to change the commit message. We can talk about the pros and cons of DCOs, but the commit history isn't the right place to do this. Could you please remove you arguments against DCOs from the commit?

If you would like to share your arguments, please do it on the cyrus development list where we can have a discussion.


For the record, the commit message
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=4acd47644ef1e1c8f8f5bc40b7cf1c5b9bcbbc4e
itself, lead to a discussion: https://www.phoronix.com/scan.php?page=news_item&px=IBM-Open-Source-Leisure-Work .

Greetings
  Дилян


---------------
commit 35b224938601f477f0ddc5173875933fd8f87fa6 (HEAD -> typos, gh/typos)
Author: Дилян Палаузов <git-...@aegee.org>
Date:   Thu May 27 11:53:46 2021 +0300

    Typos

Insisting on “DCO” imposes formalities, that serve self-purpose. One cannot assume that the committer understands English, or that the submitter has time or will to read texts about symbolism in software contributions. If the system wants
    to see the text

      nrEAUIEUAIe eEEAIUEAUEAEUAI eauaieeuai »ℓ§444.3.72b)°»°ℓ§euaieauuae

in each commit, people will write this, or any other text, that the system wants to see. All such text, which presence is mandated by the system, has the same value.

    Signed-off-by: Дилян Палаузов <git-...@aegee.org>

diff --git a/imap/carddav_db.c b/imap/carddav_db.c
index 34b81e30e..6d1d3946f 100644
--- a/imap/carddav_db.c
+++ b/imap/carddav_db.c
@@ -1204,7 +1204,7 @@ EXPORTED int carddav_store(struct mailbox *mailbox, struct vparse_card *vcard,
         goto done;
     }

-    /* Commit the append to the calendar mailbox */
+    /* Commit the append to the addressbook mailbox */
     r = append_commit(&as);
     if (r) {
         syslog(LOG_ERR, "append_commit() failed");

diff --git a/imap/http_dav_sharing.c b/imap/http_dav_sharing.c
index 8c597f402..d560a3f3a 100644
--- a/imap/http_dav_sharing.c
+++ b/imap/http_dav_sharing.c
@@ -1914,7 +1914,7 @@ HIDDEN int dav_post_share(struct transaction_t *txn, struct meth_params *pparams
     }
     if (ret) goto done;

-    /* Make sure its a share-resource element */
+    /* Make sure it is a share-resource element */
     if (!xmlStrcmp(root->name, BAD_CAST "share")) legacy = 1;
     else if (xmlStrcmp(root->name, BAD_CAST "share-resource")) {
         txn->error.desc =
diff --git a/imap/http_proxy.c b/imap/http_proxy.c
index 4a49daad4..425656047 100644
--- a/imap/http_proxy.c
+++ b/imap/http_proxy.c
@@ -657,7 +657,7 @@ static void send_response(struct transaction_t *txn, long code,
     spool_enum_hdrcache(hdrs, &write_cachehdr, txn);

     if (!body || !(len = buf_len(body))) {
-        /* Empty body -- use  payload headers from response, if any */
+        /* Empty body -- use payload headers from response, if any */
         const char **hdr;

         if ((hdr = spool_getheader(hdrs, "Transfer-Encoding"))) {



------------------------------------------
Cyrus: Devel
Permalink: 
https://cyrus.topicbox.com/groups/devel/Ta8ef4ce15e1b7785-M391c950055727c979bef2c2d
Delivery options: https://cyrus.topicbox.com/groups/devel/subscription

Reply via email to