solomax commented on a change in pull request #373: make autolable funtionality 
more flexible by introducing a locator interface that allow to specify the 
component the wicket:for refers too
URL: https://github.com/apache/wicket/pull/373#discussion_r300854397
 
 

 ##########
 File path: 
wicket-core/src/main/java/org/apache/wicket/markup/html/form/AutoLabelResolver.java
 ##########
 @@ -93,18 +93,23 @@ public Component resolve(final MarkupContainer container, 
final MarkupStream mar
                        return null;
                }
 
-               final String id = 
tag.getAttribute(getWicketNamespace(markupStream) + WICKET_FOR).trim();
+               final String path = 
tag.getAttribute(getWicketNamespace(markupStream) + WICKET_FOR).trim();
 
-               Component component = findRelatedComponent(container, id);
+               Component component = findRelatedComponent(container, path);
                if (component == null)
                {
-                       throw new ComponentNotFoundException("Could not find 
form component with id '" + id +
+                       throw new ComponentNotFoundException("Could not find 
form component with id '" + path +
 
 Review comment:
   `component with id` -> `component with path`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to