Just a few questions/comments on the code.

1. entry = ASF::Person.find(@userid).members_txt(true) does some heavy lifting 
and then a few lines later, message = "Move 
#{ASF::Person.find(@userid).member_name} to #{@action}” which lifts the same 
weight. Could this be replaced with message = "Move #{entry.member_name} to 
#{@action}”?

Or is Person.find really a lightweight function?

2. There is a section “Deceased”. Would it make sense to add a few lines of 
code for this section?

3. Where did the @action parameter come from? 

4. Could this be called directly from the command line, e.g. ruby 
views/actions/memstat clr emeritus

Craig

Craig L Russell
Secretary, Apache Software Foundation
[email protected] http://db.apache.org/jdo

Reply via email to