Github user chtyim commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/39#discussion_r32284314
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java ---
@@ -287,18 +296,20 @@ public TwillController start() {
// appMaster.jar
// org.apache.twill.internal.appmaster.ApplicationMasterMain
// false
- return launcher.prepareLaunch(
- ImmutableMap.<String, String>builder()
- .put(EnvKeys.TWILL_FS_USER, fsUser)
- .put(EnvKeys.TWILL_APP_DIR,
getAppLocation().toURI().toASCIIString())
- .put(EnvKeys.TWILL_ZK_CONNECT,
zkClient.getConnectString())
- .put(EnvKeys.TWILL_RUN_ID, runId.getId())
- .put(EnvKeys.TWILL_RESERVED_MEMORY_MB,
Integer.toString(reservedMemory))
- .put(EnvKeys.TWILL_APP_NAME, twillSpec.getName())
- .put(EnvKeys.YARN_RM_SCHEDULER_ADDRESS,
yarnConfig.get(YarnConfiguration.RM_SCHEDULER_ADDRESS))
- .build(),
- localFiles.values(), credentials
- ).addCommand(
+ ImmutableMap.Builder<String, String> builder =
ImmutableMap.<String, String>builder()
+ .put(EnvKeys.TWILL_FS_USER, fsUser)
+ .put(EnvKeys.TWILL_APP_DIR,
getAppLocation().toURI().toASCIIString())
+ .put(EnvKeys.TWILL_ZK_CONNECT, zkClient.getConnectString())
+ .put(EnvKeys.TWILL_RUN_ID, runId.getId())
+ .put(EnvKeys.TWILL_RESERVED_MEMORY_MB,
Integer.toString(reservedMemory))
+ .put(EnvKeys.TWILL_APP_NAME, twillSpec.getName())
+ .put(EnvKeys.YARN_RM_SCHEDULER_ADDRESS,
yarnConfig.get(YarnConfiguration.RM_SCHEDULER_ADDRESS));
+ if (logLevel != null) {
--- End diff --
Shall we just have the default as "INFO" (which is the current log level by
default)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
