> 
>

Thanks for the quick review.

> It would be great if we can avoid the hack into the `with_same_user`. One 
> alternative would be still pass in the `PYTEST_ADDOPTS` env variable from the 
> docker env(for development purposes) but source the setup-pytest-env within 
> each of the script.
> 

Indeed , that seems a simple enough solution, here's a rework. 

> This also makes the intention of the CI scripts clear, since sometimes we 
> could directly use these scripts. For example, I sometimes would use 
> `./tests/scripts/task_python_unittest.sh` without the docker image to run the 
> testcases

Yeah our wrapping on top uses docker most of the time and that's why I went 
with the "with_same_user" hack for a prototype but I can see that others may 
not choose to develop in the same way as us. 

R




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-tvm/pull/5421#issuecomment-618493747

Reply via email to