[quote="tqchen, post:6, topic:6334"] That dispatching logic ca certainly be simplified as a one-liner, which will reduce the memo logic addition to be about 10 loc [/quote]
Yes, the point is each derived class ends up having the exact same 10 loc. Until now we have 2 or 3 cases so that might be overlooked, but the PR by @zhiics and from my own experience made me realized that all external codegen would duplicate this 10 loc. That wouldn't be great. [quote="tqchen, post:6, topic:6334"] To be careful in the beginning, let us only put it as an internal header of relay(inside src) [/quote] Sounds good. --- [Visit Topic](https://discuss.tvm.ai/t/missing-memoization-in-exprfunctor/6334/7) to respond. You are receiving this because you enabled mailing list mode. To unsubscribe from these emails, [click here](https://discuss.tvm.ai/email/unsubscribe/b5bb17180be198e4c70acd3a5aa388cf820aaaf702888ce4fa9732939322c282).
