@optima2005 yes, I prefer a unified implementation. But that can potentially affect existing users who are using 2D only ops. Most people dont care about 3D, so if we generalize some ops for 3D and in the process introduce perf regression or other bugs to exising 2D users, they will get upset.
I think one of the requiments for adding 3D support is to introduce absolutely ZERO impact to existing 2d users. In that sense, I think creating seperate 3D implementation, which will involve some code duplication, seems not ideal but a safer bet. Can you comment? @tqchen @yzhliu @soiferj @vinx13 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/incubator-tvm/issues/4009#issuecomment-562016662
