> @jianyuh please act on the review comments @were please > https://docs.tvm.ai/contribute/code_review.html#approve-and-request-changes-explicitly
> @jianyuh please act on the review comments @were please > https://docs.tvm.ai/contribute/code_review.html#approve-and-request-changes-explicitly I addressed the comments by @FrozenGene . For @were 's comment, I took a try but somehow I got lower performance. I think it might be related to various TVM code pieces, so it might take more efforts to address. I will take a look when I have time, but it might be slow. Maybe it is better to first ship this PR and add another PR later for optimizing the performance. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/dmlc/tvm/pull/3388#issuecomment-518430378
