Not sure whether the decision has already been done but I'll put my two cents 
here.

You have covered all the tradeoffs. Since in most cases, the divisor is 
positive, I believe the important move was to add one of floordiv or 
euclideandiv (which you are doing now). The difference between floordiv and 
euclideandiv will not have drastic effect on how much we can simplify the code.

Nevertheless, IMHO, we should choose Euclidean for the followin reasons:
1) it's more important to care about ease/strength of simplification and 
analysis and less about familiarity. 
2) familiarity is a subjective matter and it depends on the audience. The 
audience of this operator (and in general Halide IR) are mostly people who are 
developing the core compiler. In the long run, this audience cares mostly about 
what's more powerful in terms of analysis, simplification, and interoperability 
with other libs and I expect people to become familiar (if they are not 
already) with euclideandiv very quickly. 



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dmlc/tvm/issues/3478#issuecomment-508761459

Reply via email to