...

The source release looks generally ok otherwise.

I'm not sure that there are enough 3rd party licenses in
toree-assembly-0.6.0-incubating.jar. It makes my heart sink when I see
these files in releases because they are a licensing nightmare.

This jar has a huge number of classes from lots of different jars,
some ASF but many other ones too. The META-INF folder has licenses for
many of them but lots of them appear to be missing.
There is also a file called LICENSE_toree-assembly-0.6.0-incubating
which might be better placed in the META-INF folder which at least
provides links to 3rd party licenses but it again seems incomplete.
I would favour including all the 3rd party licenses in META-INF explicitly.
Ones that appear to missing altogether are:
* argonaut
* shapeless
* jansi
* hawtjni
* alexarchambault/windowsansi
* neilalexander/jnacl

...

I have pushed a PR to address the items above:
https://github.com/apache/incubator-toree/pull/234

Note that I am only including the non-Apache Licenses on the distro, which
basically means argonaut and jnacl.

Please let me know if you find any other missing licenses.

-- 
Luciano Resende
http://twitter.com/lresende1975
http://lresende.blogspot.com/

Reply via email to