alitheg commented on code in PR #922:
URL:
https://github.com/apache/tooling-trusted-releases/pull/922#discussion_r2983244202
##########
atr/ssh.py:
##########
@@ -101,7 +102,14 @@ async def begin_auth(self, username: str) -> bool:
if username == "github":
log.info("GitHub authentication will use validate_public_key")
return True
-
+ try:
+ account = await ldap.account_lookup(username)
Review Comment:
I've had a think about the issue of LDAP being disabled for external
contributors before. I wonder if we should have an `ldap.enabled()` or
`ldap.is_configured()` option which tells us if it's configured or not. That
way it could be used to gate the entire LDAP section in places like this? It
would make it more explicit and would probably help the audit tool too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
