Author: rjung
Date: Sun Sep  6 16:15:40 2015
New Revision: 1701497

URL: http://svn.apache.org/r1701497
Log:
BZ 57836: ISAPI: Empty REMOTE_USER should not be
translated to "".

Still needs testing, because we rely on the
documented behavior of GetServerVariable which
is a bit unusual (returning size including
terminating '\0' character).

Modified:
    tomcat/jk/trunk/native/iis/jk_isapi_plugin.c
    tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml

Modified: tomcat/jk/trunk/native/iis/jk_isapi_plugin.c
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/iis/jk_isapi_plugin.c?rev=1701497&r1=1701496&r2=1701497&view=diff
==============================================================================
--- tomcat/jk/trunk/native/iis/jk_isapi_plugin.c (original)
+++ tomcat/jk/trunk/native/iis/jk_isapi_plugin.c Sun Sep  6 16:15:40 2015
@@ -3560,8 +3560,12 @@ static char *dup_server_value(LPEXTENSIO
     char buf[HDR_BUFFER_SIZE];
     char *dp;
 
-    if (lpEcb->GetServerVariable(lpEcb->ConnID, (LPSTR)name, buf, &sz))
+    if (lpEcb->GetServerVariable(lpEcb->ConnID, (LPSTR)name, buf, &sz)) {
+        if (sz == 0) {
+            return NULL;
+        }
         return jk_pool_strdup(p, buf);
+    }
     if (GetLastError() != ERROR_INSUFFICIENT_BUFFER)
         return NULL;
     if ((dp = jk_pool_alloc(p, sz))) {

Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=1701497&r1=1701496&r2=1701497&view=diff
==============================================================================
--- tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Sun Sep  6 16:15:40 2015
@@ -44,6 +44,10 @@
   <br />
   <subsection name="Native">
     <changelog>
+      <fix>
+        <bug>57836</bug>: ISAPI: Empty REMOTE_USER should not be
+        translated to "". (rjung)
+      </fix>
       <update>
         <bug>58309</bug>: ISAPI: Update bundled pcre from version 5.0
         to 8.37. (rjung)



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to