https://bz.apache.org/bugzilla/show_bug.cgi?id=58327

--- Comment #1 from Mark Thomas <ma...@apache.org> ---
The only risk I can see is that even though the ValueExpression is read-only,
the object it wraps is not and that object may change over time. That may
change the result of its toString() method which in turn would impact the
result of #getExpressionString(). However, the use of toString() here is an
implementation detail internal to Tomcat. The spec has no expectations of what
should be produced for #getExpressionString() in this case.

On balance I think the potential performance benefits outweigh the possible
confusion that might be caused by caching the toString() value if
getExpressionString() is used for debugging. I'll look at getting this patch
applied.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to