https://bz.apache.org/bugzilla/show_bug.cgi?id=58187

--- Comment #8 from remi.lebast...@flexcom.lu ---
Thank you for the time you spend for this report. I will try to be the more
precise I can. 

Steps to reproduce:

On Tomcat 7.0.61:
- Take the Tomcat v7.0.61 from the archives
- Don't change anything to configuration (all parameters are leaved to default
values (autoDeploy is true for example)) except the tomcat-users.xml file to
access the manager
- Put the WAR provided in the webapp folder to start it as soon as Tomcat
starts
- Start the Tomcat servers and wait for it completes its start (and the
deployment of all applications)
- Call the URL
http://localhost:8080/manager/text/deploy?path=/sample&war=file:C:/sample.war&update=true
with the same WAR that has been dropped in webapp folder (of course the paths
need to be adapted)
- See that on browser, the OK response appears AFTER the undeploy and redeploy
of the WAR provided

On Tomcat 7.0.62:
- Take the Tomcat v7.0.62 from the archives
- Don't change anything to configuration (all parameters are leaved to default
values (autoDeploy is true for example)) except the tomcat-users.xml file to
access the manager
- Put the WAR provided in the webapp folder to start it as soon as Tomcat
starts
- Start the Tomcat servers and wait for it completes its start (and the
deployment of all applications)
- Call the URL
http://localhost:8080/manager/text/deploy?path=/sample&war=file:C:/sample.war&update=true
with the same WAR that has been dropped in webapp folder (of course the paths
need to be adapted)
- See that on browser, the OK response appears BEFORE the undeploy and redeploy
of the WAR provided


Platforms tested:
- Windows 7
- Linux Ubuntu 10.04
- JDK 1.7.0.67


War file:
https://tomcat.apache.org/tomcat-7.0-doc/appdev/sample/


What I mean by the response appears BEFORE is that the method
"writeDeployResult" of the "ManagerServlet" is called BEFORE methods "undeploy"
and "deployWAR" of the HostConfig class are called.

I have searched in the source code why the behaviour have changed and you are
totally right: it's not the manager that have changed but the
org.apache.catalina.startup.HostConfig class that causes the change of
behaviour (due to correction of another bug).


The change in source code is this one : 

On Tomcat 7.0.62:
....
// File.lastModified() has a resolution of 1s (1000ms). The last
// modified time has to be more than 1000ms ago to ensure that
// modifications that take place in the same second are not
// missed. See Bug 57765.
if (resource.lastModified() != lastModified && (!host.getAutoDeploy() ||
resource.lastModified() < currentTimeWithResolutionOffset)) {....

On Tomcat 7.0.61:
....
if (resource.lastModified() > lastModified) {....

I will not reopen that bug but let your reopen it if you considered it as a bug
but definitively, there was a change in the code that have an impact on the
deployment of application.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to