On 09/07/2015 18:50, Violeta Georgieva wrote: > 2015-07-09 15:56 GMT+03:00 Konstantin Kolinko <knst.koli...@gmail.com>:
<snip/> >> Reviewing DeployTask.java further (the code touched by >> http://svn.apache.org/r1689941 ) >> >> For current trunk: >> > http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ant/DeployTask.java?view=markup#l156 <snip/> >> 2. I wonder whether "2Gb" file upload size limit here is needed. >> >> Maybe we can s/int contentLength/long contentLength/ and allow such >> big files. There is a configurable file upload limit on Tomcat side >> (50Mb, in web.xml of manager webapp), though maybe it is not applied >> to PUT request used here. > > Yep but the restriction in manager app is only when multipart is used. Here > this is not the case. So we can allow bigger files? No objections in principle to larger files. A limit above Integer.MAX_VALUE is going to require some minor API and code changes to the Ant tasks as content length is currently handled as an int. A quick look at the Manager code suggests that any size is acceptable. So, assuming the necessary int -> long changes changes are made - no objections here. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
