On 06/07/2015 14:18, Violeta Georgieva wrote: > Hi Mark, > > 2015-07-06 15:53 GMT+03:00 <ma...@apache.org>: >> >> Author: markt >> Date: Mon Jul 6 12:53:56 2015 >> New Revision: 1689392 >> >> URL: http://svn.apache.org/r1689392 >> Log: >> Remove unnecessary code > > Is the trigger for this change only that it is not necessary or something > else?
Just that it isn't necessary. All it does is call the super class that has the exact same signature. > For example I'm using this in OSGi environment. You might need to re-compile but this should still work exactly the same way with no code changes. If that is not the case I'm happy to restore the code but I'd like to understand why. Mark > > Regards, > Violeta > >> Modified: >> > tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardContext.java >> >> Modified: > tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardContext.java >> URL: > http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardContext.java?rev=1689392&r1=1689391&r2=1689392&view=diff >> > ============================================================================== >> --- > tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardContext.java > (original) >> +++ > tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardContext.java Mon > Jul 6 12:53:56 2015 >> @@ -88,7 +88,6 @@ import org.apache.catalina.Lifecycle; >> import org.apache.catalina.LifecycleException; >> import org.apache.catalina.LifecycleListener; >> import org.apache.catalina.LifecycleState; >> -import org.apache.catalina.Loader; >> import org.apache.catalina.Manager; >> import org.apache.catalina.Pipeline; >> import org.apache.catalina.Realm; >> @@ -1990,19 +1989,6 @@ public class StandardContext extends Con >> } >> >> >> - /** >> - * Set the Loader with which this Context is associated. >> - * >> - * @param loader The newly associated loader >> - */ >> - @Override >> - public synchronized void setLoader(Loader loader) { >> - >> - super.setLoader(loader); >> - >> - } >> - >> - >> /** >> * Return the boolean on the annotations parsing. >> */ >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org