Author: markt
Date: Fri Jun 26 08:54:08 2015
New Revision: 1687719
URL: http://svn.apache.org/r1687719
Log:
Add unit tests for settings frames.
Added:
tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_5.java (with
props)
Added: tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_5.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_5.java?rev=1687719&view=auto
==============================================================================
--- tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_5.java (added)
+++ tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_5.java Fri Jun
26 08:54:08 2015
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.coyote.http2;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+/**
+ * Unit tests for Section 6.4 of
+ * <a href="https://tools.ietf.org/html/rfc7540";>RFC 7540</a>.
+ * <br>
+ * The order of tests in this class is aligned with the order of the
+ * requirements in the RFC.
+ */
+public class TestHttp2Section_6_5 extends Http2TestBase {
+
+
+ @Test
+ public void testSettingsFrameNonEmptAck() throws Exception {
+ // HTTP2 upgrade
+ http2Connect();
+
+ sendSettings(0, true, new Setting(1,1));
+
+ // Go away
+ parser.readFrame(true);
+
+ Assert.assertTrue(output.getTrace(), output.getTrace().startsWith(
+ "0-Goaway-[1]-[" + Http2Error.FRAME_SIZE_ERROR.getCode() +
"]-["));
+ }
+
+
+ @Test
+ public void testSettingsFrameNonZeroStream() throws Exception {
+ // HTTP2 upgrade
+ http2Connect();
+
+ sendPriority(3, 0, 15);
+ sendSettings(3, true, new Setting(1,1));
+
+ // Go away
+ parser.readFrame(true);
+
+ Assert.assertTrue(output.getTrace(), output.getTrace().startsWith(
+ "0-Goaway-[1]-[" + Http2Error.PROTOCOL_ERROR.getCode() +
"]-["));
+ }
+
+
+ @Test
+ public void testSettingsFrameWrongLength() throws Exception {
+ // HTTP2 upgrade
+ http2Connect();
+
+ byte[] resetFrame = new byte[10];
+ // length
+ ByteUtil.setThreeBytes(resetFrame, 0, 1);
+ // type
+ resetFrame[3] = FrameType.SETTINGS.getIdByte();
+ // No flags
+ // Stream ID 0
+
+ // Payload - left as zero
+
+ os.write(resetFrame);
+ os.flush();
+
+ // Read GOAWAY frame
+ parser.readFrame(true);
+
+ Assert.assertTrue(output.getTrace(), output.getTrace().startsWith(
+ "0-Goaway-[1]-[" + Http2Error.FRAME_SIZE_ERROR.getCode() +
"]-["));
+ }
+
+
+ // Need to test sending push promise when push promise suport is disabled
+
+ @Test
+ public void testSettingsFrameInvalidPushSetting() throws Exception {
+ // HTTP2 upgrade
+ http2Connect();
+
+ sendSettings(0, false, new Setting(0x2,0x2));
+
+ // Go away
+ parser.readFrame(true);
+
+ Assert.assertTrue(output.getTrace(), output.getTrace().startsWith(
+ "0-Goaway-[1]-[" + Http2Error.PROTOCOL_ERROR.getCode() +
"]-["));
+ }
+
+
+ @Test
+ public void testSettingsFrameInvalidWindowSizeSetting() throws Exception {
+ // HTTP2 upgrade
+ http2Connect();
+
+ sendSettings(0, false, new Setting(0x4,1 << 31));
+
+ // Go away
+ parser.readFrame(true);
+
+ Assert.assertTrue(output.getTrace(), output.getTrace().startsWith(
+ "0-Goaway-[1]-[" + Http2Error.FLOW_CONTROL_ERROR.getCode() +
"]-["));
+ }
+
+
+ @Test
+ public void testSettingsFrameInvalidMaxFrameSizeSetting() throws Exception
{
+ // HTTP2 upgrade
+ http2Connect();
+
+ sendSettings(0, false, new Setting(0x5,1 << 31));
+
+ // Go away
+ parser.readFrame(true);
+
+ Assert.assertTrue(output.getTrace(), output.getTrace().startsWith(
+ "0-Goaway-[1]-[" + Http2Error.PROTOCOL_ERROR.getCode() +
"]-["));
+ }
+
+
+ @Test
+ public void testSettingsUnknownSetting() throws Exception {
+ // HTTP2 upgrade
+ http2Connect();
+
+ sendSettings(0, false, new Setting(0xFF,0xFF));
+
+ // Ack
+ parser.readFrame(true);
+
+ Assert.assertTrue(output.getTrace(), output.getTrace().startsWith(
+ "0-Settings-Ack"));
+ }
+
+ // delayed ACKs. Requires an API (TBD) for applications to send settings.
+}
Propchange: tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_5.java
------------------------------------------------------------------------------
svn:eol-style = native
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
