Author: markt Date: Thu Jun 4 20:58:15 2015 New Revision: 1683643 URL: http://svn.apache.org/r1683643 Log: Fix a TODO
Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java?rev=1683643&r1=1683642&r2=1683643&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java (original) +++ tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java Thu Jun 4 20:58:15 2015 @@ -169,11 +169,7 @@ public class Http2UpgradeHandler extends String base64Settings = stream.getCoyoteRequest().getHeader(HTTP2_SETTINGS_HEADER); byte[] settings = Base64.decodeBase64(base64Settings); - if (settings.length % 6 != 0) { - // Invalid payload length for settings - // TODO i18n - throw new ProtocolException(); - } + FrameType.SETTINGS.checkPayloadSize(connectionId, 1, settings.length); for (int i = 0; i < settings.length % 6; i++) { int id = ByteUtil.getTwoBytes(settings, i * 6); --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org