https://bz.apache.org/bugzilla/show_bug.cgi?id=57701

--- Comment #3 from Mark Thomas <ma...@apache.org> ---
I'm not convinced of the need for this feature but I don't object to it being
added.

Overall the patch looks good. There is the odd s/reload/redploy/ required but
that looks like copy/paste errors and is easily fixed.

I'm more concerned that the actual redeploy code is not correct. The issues I
could see from a code inspection (I haven't tried applying the patch) are:
 - it assumes that the web application is deployed as a WAR
 - it assumes autoDeployment is enabled
 - it doesn't mark the web application as being serviced

I'd expect to see the following:
 - the context marked as serviced
 - the context removed from the host
 - check() being used to redeploy it
 - the serviced mark removed from the host

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to