On 09/05/2015 08:45, Martin Grigorov wrote:
> Hi Mark,
>
> On Fri, May 8, 2015 at 3:32 PM, <ma...@apache.org> wrote:
>
>> Author: markt
>> Date: Fri May 8 12:32:11 2015
>> New Revision: 1678339
>>
>> URL: http://svn.apache.org/r1678339
>> Log:
>> Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=54618
>> Add the HSTS header by default as recommended by RFC 7527
<snip/>
>> + public void setHstsMaxAgeSeconds(int hstsMaxAgeSeconds) {
>> + if (hstsMaxAgeSeconds < 0) {
>> + hstsMaxAgeSeconds = 0;
>>
>
> 1. Is 'this.' missing here ? ^^
It is. Thanks for catching that. I'll get that fixed.
> 2. Who is responsible to call the setters? I'd expect filter init-params to
> be used but since they are not read in #init() it seems there is an other
> way.
That should be handled in FilerBase.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
