> From: Christopher Schultz [mailto:ch...@christopherschultz.net] > Subject: Re: svn commit: r1676864 - in /tomcat/native/trunk/native: > include/ssl_private.h src/sslcontext.c
> > Modified: tomcat/native/trunk/native/src/sslcontext.c > > URL: > > http://svn.apache.org/viewvc/tomcat/native/trunk/native/src/sslcontext.c? > > rev=1676864&r1=1676863&r2=1676864&view=diff > > ============================================================================== > > --- tomcat/native/trunk/native/src/sslcontext.c (original) > > +++ tomcat/native/trunk/native/src/sslcontext.c Wed Apr 29 21:31:43 2015 > > @@ -206,9 +231,14 @@ TCN_IMPLEMENT_CALL(jlong, SSLContext, ma > > SSL_CTX_set_default_passwd_cb_userdata(c->ctx, (void > > *)(&tcn_password_callback)); > > SSL_CTX_set_info_callback(c->ctx, SSL_callback_handshake); > > > > - /* Set Server Name Indication (SNI) callback */ > > - c->jnienv = e; > > - c->java_object = o; > > + /* Cache Java side SNI callback if not already cached */ > > + if (ssl_context_class == 0) { > This is okay, but graybeards might prefer: > if(!ssl_context_class) And the purists among us (even with a gray beard) would much prefer: if (ssl_context_class == NULL) { Treating a pointer as a boolean is close to an abomination (although it is quite typical C bad practice). Just because C has a horribly weak typing system doesn't mean abusing it should be encouraged. - Chuck THIS COMMUNICATION MAY CONTAIN CONFIDENTIAL AND/OR OTHERWISE PROPRIETARY MATERIAL and is thus for use only by the intended recipient. If you received this in error, please contact the sender and delete the e-mail and its attachments from all computers. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
