https://bz.apache.org/bugzilla/show_bug.cgi?id=57707
Christopher Schultz <ch...@christopherschultz.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|INVALID |---
Severity|normal |enhancement
Status|RESOLVED |REOPENED
--- Comment #10 from Christopher Schultz <ch...@christopherschultz.net> ---
One could argue that, if doing something as technical as preparing an RPM spec
file, you probably should have at least skimmed the BUILDING.txt file to see
what the requirements were for building a release build.
Anyhow, in an effort to avoid Konstantin's -1 to your patch, I was going to try
to do this:
<exec executable="wine" osfamily="unix" resultproperty="need-wine">
...
</exec>
<fail if="need-wine">
Blah
</fail>
But for some reason, I can't get the <exec> to NOT fail-on-error. I even tried
setting failonerror="false" (which is the default) but it still fails early:
installer:
[echo] Builds a Windows installer based on Nullsoft Installer
[copy] Copying 1 file to /.../tomcat-7.0.x/output/dist
BUILD FAILED
/.../tomcat-7.0.x/build.xml:2126: Execute failed: java.io.IOException: Cannot
run program "wine" (in directory "/.../tomcat-7.0.x/output/dist"): error=2, No
such file or directory
Note that, in the above error output, the "installer" target already has an
"echo" that tells you what it's doing: "Builds a Windows installer based on
Nullsoft Installer". The only thing you really added in your proposed patch was
the note about the "skip.installer" property.
I agree with Konstantin that anyone who doesn't understand the error, here,
should read the BUILDING.txt file for guidance. The searchability of
BUILDING.txt for "Wine" (or "wine" or "WINE", or "WiNe") is tough to fix for
all possible combinations of case. Case-insensitive search, perhaps?
If you want to spend some time on a patch for build.xml that directs the user
to BUILDING.txt if executing "wine" fails, I'd be happy to review and commit
it, but I'm not going to bang my /own/ head against ant to get this solved.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
