https://bz.apache.org/bugzilla/show_bug.cgi?id=57708
--- Comment #3 from Mark Thomas <ma...@apache.org> --- I've taken a quick look at the patch for 9.0.x. I suspect that my comments will apply equally to the back-ports. Overall, +1. I'd change some of the details (see below) but the general approach looks sound. I'm happy fixing the details when I apply the patch so no need to re-submit. On those details: - 'remote user' has a specific meaning in a servlet container. I think this needs to be changed to 'AJP authenticated user'or something similar. - The indentation is inconsistent (it should be four spaces). Some of that is because the patch is trying to follow the existing code which itself is not very consistent. In particular, the continuation lines look odd. - There is clearly some scope for refactoring to reduce duplication in the authenticators. That should be completed first. I'm a little wary of adding a new method to Realm but, we have done that before when the need arose and there is an implementation in RealmBase so the impact should be minimal. Thanks for the patch. This is on my todo list for tomorrow. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
