2015-02-25 16:07 GMT+01:00 Felix Schumacher < felix.schumac...@internetallee.de>:
> Am 25.02.2015 15:34, schrieb r...@apache.org: > + first = false; > This is not really threadsafe. What happens when more than one thread > call this method while first==false? They could (probably really really > rarely) happen to get into this if condition at the "same" time, set first > to false and do nothing. My reading would be, that this should happen only > for the first call. Maybe thread safety isn't an issue, but do we need > volatile in that case? > > If it actually fixes something, it'll be improved and then fully redone. Rémy