On 23/02/2015 12:07, Rémy Maucherat wrote: > 2015-02-23 12:26 GMT+01:00 <ma...@apache.org>: > >> Author: markt >> Date: Mon Feb 23 11:26:56 2015 >> New Revision: 1661642 >> >> URL: http://svn.apache.org/r1661642 >> Log: >> Don't default to an infinite timeout for write. Generally, writes should >> happen (fairly) quickly. >> > This is messing up some tests for me. > > Although I don't understand why it was working before, I indeed have a NIO2 > test hanging on close (the TestWebSocketFrameClientSSL one with the error > and the backlog). The close actually does a blocking write, which I tried > removing successfully. Can we try that instead ?
I'm not sure if that is fixing the symptom or the cause. I'm still seeing something going wrong with what should be a clean shutdown in TestWsWebSocketContainer.testMaxMessageSize04(). I took a look at the source for BufferedOutputStream and that does flush on close. I think ServletOutputStream should behave the same way. Disabling the flush might give us some insight into what else might be going wrong but I don't think disabling is a long term solution. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
