Thanks for your guidance in this Mark and Chris. Hope my first fix will be accepted.
On Wed, Feb 11, 2015 at 5:16 PM, Mark Thomas <ma...@apache.org> wrote: > On 11/02/2015 11:32, Pravallika Peddi wrote: > > Hi Mark, > > > > I have created the patch file as you mentioned and attached it to the bug > > report, i would like to confirm on one thing: > > > > I have added two new strings to the LocalStrings.properties file which > has > > Locale specific strings. Some one has to help to add the new strings to > the > > other Locale files like Japaneese, france, etc... > > Don't worry about those. They can be completed later. > > > Another query is: When can i mark the issue as RESOLVED? > > You don't. A committer will mark this issue as fixed once they have > review and applied your patch. > > > and who will verify my patch to make sure it is working? > > This is the responsibility of the committer who commits the patch. > > > From my side i verified the fix. > > Great. > > One of the committers will look at this shortly. > > Mark > > > > > > On Wed, Feb 11, 2015 at 2:43 PM, Mark Thomas <ma...@apache.org> wrote: > > > >> On 11/02/2015 06:25, Pravallika Peddi wrote: > >>> Hi Mark, > >>> Attached the fix details. > >> > >> Patches should be in diff -u format and attached to the bug report to > >> which they relate. > >> > >> Mark > >> > >> > >>> I have modified AprLifecycleListener.java and Library.java to fix the > >>> issue. Added a new file "LibraryNotFoundError.java" in > >>> "org.apache.tomcat.jni" package. Added two new strings in > >>> "LocalStrings.properties" file located in "org.apache.catalina.core" > >>> package. I do not know the other languages so did not add the new > >>> strings in other property files. > >>> > >>> > >>> I tested the fix and attached the log files as well. > >>> I provided the fix based on the comments provided in the issue. > >>> > >>> I did not implement the 3rd point(C) yet as i did not feel it so > >>> important. Let me know if it is required so that i can fix the third > >>> point too. > >>> > >>> Please validate the fix so that i can commit to svn. > >>> > >>> Thanks, > >>> VIN > >>> > >>> On Tue, Feb 10, 2015 at 5:15 PM, Pravallika Peddi > >>> <reachme.va...@gmail.com <mailto:reachme.va...@gmail.com>> wrote: > >>> > >>> Got you Mark. > >>> Now i am able to reproduce the problem by keeping I64 bit dll in > x64 > >>> bit windows platform. > >>> I will fix it and let you know. > >>> > >>> Thanks, > >>> VIN > >>> > >>> On Tue, Feb 10, 2015 at 2:19 PM, Mark Thomas <ma...@apache.org > >>> <mailto:ma...@apache.org>> wrote: > >>> > >>> On 10/02/2015 06:28, Pravallika Peddi wrote: > >>> > Thanks Chris for the information. > >>> > > >>> > Mark & Chris: > >>> > I have gone through one of the issues given by Mark: > >>> > > >>> > https://issues.apache.org/bugzilla/show_bug.cgi?id=57021 > >>> > > >>> > and found that this issue is fixed already. > >>> > > >>> > Steps i performed: > >>> > 1) Download Tomcat 6.0 - 32 bit version and run it on 32-bit > >> Windows > >>> > platform. Tomcat Server started successfully using commands > >> mentioned in > >>> > issue. Stop the tomcat. Check the catalina.out folder and it > >> has no > >>> > error messages. Rename catalina.out file. > >>> > > >>> > 2) Download Tomcat 6.0-64 bit version and extract > tcnative-dll > >> and copy > >>> > it on to 32-bit Tomcat folder. Start the Tomcat Server and > >> check the > >>> > catalina.out file. It has proper error message "Feb 10, 2015 > >> 11:42:54 AM > >>> > org.apache.catalina.core.AprLifecycleListener init > >>> > INFO: The APR based Apache Tomcat Native library which allows > >> optimal > >>> > performance in production environments was not found on the > >>> > java.library.path:" > >>> > > >>> > and i did not observe any error in command line as mentioned > >> in the issue. > >>> > > >>> > I attached both the catalina.out files for your reference. > >>> > Even i checked the recent Trunk AppLifecycleListener.init() > >> java method > >>> > and did not find the source code that was mentioned in the > >> issue. > >>> > > >>> > Hence i feel the issue is fixed. > >>> > Please confirm so that i will close the issue. > >>> > >>> The issue is not fixed. Tomcat isn't finding the tc-native > >>> library so > >>> the error isn't triggering. > >>> > >>> Mark > >>> > >>> > >> --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > >>> <mailto:dev-unsubscr...@tomcat.apache.org> > >>> For additional commands, e-mail: dev-h...@tomcat.apache.org > >>> <mailto:dev-h...@tomcat.apache.org> > >>> > >>> > >>> > >>> > >>> > >>> > >>> --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > >>> For additional commands, e-mail: dev-h...@tomcat.apache.org > >>> > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > >> For additional commands, e-mail: dev-h...@tomcat.apache.org > >> > >> > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
