https://issues.apache.org/bugzilla/show_bug.cgi?id=57546
Konstantin Kolinko <knst.koli...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Component|WebSocket |WebSocket
Version|8.0.18 |7.0.59
Resolution|FIXED |---
Product|Tomcat 8 |Tomcat 7
Target Milestone|---- |---
--- Comment #6 from Konstantin Kolinko <knst.koli...@gmail.com> ---
Only the first part of the fix was applied to Tomcat 7 (r1658738).
The second part was applied to Tomcat 8 (r1658794), but has not been ported to
Tomcat 7 yet. Thus I am REOPENing this issue, so that it is not forgotten.
The issues in the first part:
- as noted by Remy (in "Re: r1658734"):
> Good find, but what happens if onDataAvailable or onWritePossible throw a
runtime exception (like a NPE), since this is user code. It could also leak
then ? Shouldn't the code catch everything, also call onError on the
listener and close ?
- as noted by Chris (in "Re: r1658737"):
> Is it worth predicating the log call with if(getLog().isDebugEnabled)?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
