On 10/02/2015 15:59, Rémy Maucherat wrote:
> 2015-02-10 16:43 GMT+01:00 <ma...@apache.org>:
> 
>> Author: markt
>> Date: Tue Feb 10 15:43:46 2015
>> New Revision: 1658734
>>
>> URL: http://svn.apache.org/r1658734
>> Log:
>> Ensure that a dropped connection does not leave references to the
>> UpgradeProcessor
>>
> Good find, but what happens if onDataAvailable or onWritePossible throw a
> runtime exception (like a NPE), since this is user code. It could also leak
> then ? Shouldn't the code catch everything, also call onError on the
> listener and close ?
Good point. I was thinking purely in terms of WebSocket but you are
right - this needs to be more general. I'll take another look.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to