On 05/02/2015 14:40, Mark Thomas wrote: > On 05/02/2015 14:36, Konstantin Kolinko wrote: >> 2015-02-05 17:28 GMT+03:00 <ma...@apache.org>: >>> Author: markt >>> Date: Thu Feb 5 14:28:37 2015 >>> New Revision: 1657580 >>> >>> URL: http://svn.apache.org/r1657580 >>> Log: >>> First pass at reducing false failures on CI system. >>> >>> Modified: >>> tomcat/trunk/build.xml >>> tomcat/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java >>> >> >>> Modified: >>> tomcat/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java >>> URL: >>> http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java?rev=1657580&r1=1657579&r2=1657580&view=diff >>> ============================================================================== >>> --- tomcat/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java >>> (original) >>> +++ tomcat/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java >>> Thu Feb 5 14:28:37 2015 >>> @@ -31,8 +31,10 @@ import org.apache.catalina.connector.Res >>> >>> public class TesterAccessLogValve extends ValveBase implements AccessLog { >>> >>> - // Timing tests need a small error margin to prevent failures >>> - private static final long ERROR_MARGIN = 500; >>> + private static boolean RELAX_TIMING = >>> Boolean.getBoolean("tomcat.test.relaxTiming"); >> >> 1. "final" above > > Done. > >>> + // Timing tests need an error margin to prevent failures. >>> + private static final long ERROR_MARGIN = RELAX_TIMING ? 1000 : 100; >>> >>> private final List<Entry> entries = new ArrayList<>(); >> >> >> 2. Mention the new "test.relaxTiming" build property in BUILDING.txt >> -> "(7.3) Other configuration options" > > Will do. > >> 3. System.out.println() added in >> http://svn.apache.org/r1657492 >> can be replaced by log.info(). The log is available is the test class >> inherits from o.a.c.startup.LoggingBaseTest. > > Grr. That wasn't meant to get committed. It is just me checking that the > config took effect.
Ah. wrong System.out.println(). I'll get that one changed. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
