Mark,

On 1/30/15 9:23 AM, ma...@apache.org wrote:
> Author: markt
> Date: Fri Jan 30 14:23:00 2015
> New Revision: 1656022
> 
> URL: http://svn.apache.org/r1656022
> Log:
> Clean-up

Good catch. There are very few places in Tomcat where there are
workarounds for JVM bugs (except for the whole load-classes-on-startup
thing, which is actually quite a good strategy). Are they easy to find?
This one was well-documented, and could have been found by grep'ing for
"J2SE". Any idea if others are lurking that can also easily be found?

-chris

> Modified:
>     tomcat/trunk/java/org/apache/tomcat/util/net/SSLImplementation.java
> 
> Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SSLImplementation.java
> URL: 
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/SSLImplementation.java?rev=1656022&r1=1656021&r2=1656022&view=diff
> ==============================================================================
> --- tomcat/trunk/java/org/apache/tomcat/util/net/SSLImplementation.java 
> (original)
> +++ tomcat/trunk/java/org/apache/tomcat/util/net/SSLImplementation.java Fri 
> Jan 30 14:23:00 2015
> @@ -58,23 +58,12 @@ public abstract class SSLImplementation
>              return getInstance();
>  
>          try {
> -            // Workaround for the J2SE 1.4.x classloading problem (under
> -            // Solaris).
> -            // Class.forName(..) fails without creating class using new.
> -            // This is an ugly workaround.
> -            if (JSSEImplementationClass.equals(className)) {
> -                return new 
> org.apache.tomcat.util.net.jsse.JSSEImplementation();
> -            }
>              Class<?> clazz = Class.forName(className);
>              return (SSLImplementation) clazz.newInstance();
>          } catch (Exception e) {
>              if (logger.isDebugEnabled())
> -                logger
> -                        .debug("Error loading SSL Implementation " + 
> className,
> -                                e);
> -            throw new ClassNotFoundException(
> -                    "Error loading SSL Implementation " + className + " :"
> -                            + e.toString());
> +                logger.debug("Error loading SSL Implementation " + 
> className, e);
> +            throw new ClassNotFoundException("Error loading SSL 
> Implementation " + className, e);
>          }
>      }
>  
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to