On 28/01/2015 14:39, Christopher Schultz wrote: > Mark, > > On 1/27/15 2:39 PM, ma...@apache.org wrote: >> Author: markt >> Date: Tue Jan 27 19:39:03 2015 >> New Revision: 1655132 >> >> URL: http://svn.apache.org/r1655132 >> Log: >> Start tends to make extensive use of resources. Trigger a clean-up once >> it finishes. >> >> Modified: >> tomcat/trunk/java/org/apache/catalina/core/StandardContext.java >> >> Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java >> URL: >> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardContext.java?rev=1655132&r1=1655131&r2=1655132&view=diff >> ============================================================================== >> --- tomcat/trunk/java/org/apache/catalina/core/StandardContext.java >> (original) >> +++ tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Tue Jan >> 27 19:39:03 2015 >> @@ -5216,6 +5216,9 @@ public class StandardContext extends Con >> broadcaster.sendNotification(notification); >> } >> >> + // Trigger clean-up of the resources >> + getResources().backgroundProcess(); > > I think it would be better to have a "cleanupResources" method that gets > called from backgroundProcess, and to call cleanupResources here instead. > > Calling backgroundProcess here seems architecturally unsound.
Fair point. I'll get that fixed. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
